Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert default networks no matter if they are available or not #1436

Closed
LuizAsFight opened this issue Aug 28, 2024 · 0 comments · Fixed by #1437
Closed

Insert default networks no matter if they are available or not #1436

LuizAsFight opened this issue Aug 28, 2024 · 0 comments · Fixed by #1437
Assignees
@helciofranco
Labels
bug Something isn't working p0 For yesterday. critical bugs / big priorities

Comments

@LuizAsFight
Copy link
Contributor

LuizAsFight commented Aug 28, 2024 •
edited
Loading

recently we changed the addDefaultNetwork method to include devnet, the problem is that sometimes the devnet may be off, and this is breaking the signup flow, not allowing the user to finish the setup of his wallet after setting the password.

this issue aims to fix this problem and make the networks added directly no matter if they are online or not.
@LuizAsFight LuizAsFight added bug Something isn't working p0 For yesterday. critical bugs / big priorities labels Aug 28, 2024
@LuizAsFight LuizAsFight changed the title make devnet network inserted if it is not available insert default networks no matter if they are available or not Aug 28, 2024
@helciofranco helciofranco self-assigned this Aug 28, 2024
@helciofranco helciofranco linked a pull request Aug 28, 2024 that will close this issue
fix: add default networks regardless if they're down #1437
Merged
@helciofranco helciofranco mentioned this issue Aug 28, 2024
Merged
@helciofranco helciofranco changed the title insert default networks no matter if they are available or not Insert default networks no matter if they are available or not Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@helciofranco helciofranco

Labels
bug Something isn't working p0 For yesterday. critical bugs / big priorities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add default networks regardless if they're down FuelLabs/fuels-wallet
2 participants
@helciofranco @LuizAsFight