Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FuelWallet Extension › SDK operations - e2e test failing #1262

Closed
HoTandy opened this issue Apr 30, 2024 · 0 comments · Fixed by #1290
Closed

FuelWallet Extension › SDK operations - e2e test failing #1262

HoTandy opened this issue Apr 30, 2024 · 0 comments · Fixed by #1290
Assignees
@arthurgeron
Labels
bug Something isn't working e-testnet-launch https://github.com/FuelLabs/edge/issues/140 p0 For yesterday. critical bugs / big priorities

Comments

@HoTandy
Copy link
Contributor

HoTandy commented Apr 30, 2024 •
edited
Loading

The following e2e test is failing on my machine.

FuelWallet Extension › SDK operations

Image

Steps to reproduce.

  1. Clone fuels-wallet repo
  2. pnpm install
  3. pnpm exec playwright install --with-deps chromium
  4. cp packages/app/.env.example packages/app/.env (to setup our network)
  5. pnpm node:up (to start a local fuel node)
  6. pnpm dev:crx (to start the extension locally)
  7. In a new terminal, run pnpm test:e2e

Expected:

All e2e tests should pass

Additionally, the test also fails in the IDE (not just from the command line):

image

ARM based:
ProductName: macOS
ProductVersion: 14.4.1
BuildVersion: 23E224
Chrome: Version 124.0.6367.78 (Official Build) (arm64)
@HoTandy HoTandy added the bug Something isn't working label Apr 30, 2024
@LuizAsFight LuizAsFight added the p0 For yesterday. critical bugs / big priorities label May 2, 2024
@LuizAsFight LuizAsFight mentioned this issue May 16, 2024
Merged
arthurgeron added a commit that referenced this issue May 28, 2024
@arthurgeron @LuizAsFight
@fuel-service-user @github-actions
fix: flaky e2e tests (#1290)
57f87f8 
Closes #1298 
Closes #1262 
- Re-enabled E2E contract tests
- Fixed biome trying to validate files generated by playwright test runs
- Fixed Playwright tests starting up before CRX files are available, now
runs `build` beforehand.
- Fixed CRX dev server reloading during playwright tests, causing
instabilities
- Fixed NODE_ENV being set to default (production) on local E2E tests,
leading to the wrong version (i.e. production) being installed
- Fixed bug where only the first test file in a suite run would use the
local CRX build, it'd then download and use a production build of the
Wallet for the rest

---------

Co-authored-by: Luiz Gomes - LuizAsFight.eth <[email protected]>
Co-authored-by: fuel-service-user <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@LuizAsFight LuizAsFight added the e-testnet-launch https://github.com/FuelLabs/edge/issues/140 label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arthurgeron arthurgeron

Labels
bug Something isn't working e-testnet-launch https://github.com/FuelLabs/edge/issues/140 p0 For yesterday. critical bugs / big priorities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: flaky e2e tests FuelLabs/fuels-wallet
3 participants
@arthurgeron @LuizAsFight @HoTandy