Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document hidden tx summary methods #3408

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Nov 20, 2024

Summary

This PR adds some hidden tx summary methods to the API docs.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Dhaiwat10 Dhaiwat10 self-assigned this Nov 20, 2024
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:46am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:46am
ts-docs-api ❌ Failed (Inspect) Nov 22, 2024 8:46am

@Dhaiwat10 Dhaiwat10 changed the title Dp/tx summary docs docs: document hidden tx summary methods Nov 20, 2024
@github-actions github-actions bot added the docs Requests pertinent to documentation label Nov 20, 2024
Copy link

codspeed-hq bot commented Nov 20, 2024

CodSpeed Performance Report

Merging #3408 will not alter performance

Comparing dp/tx-summary-docs (8066a7d) with master (27e8808)

Summary

✅ 18 untouched benchmarks

Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

@@ -42,15 +42,24 @@ import type {
AbiMap,
} from './types';

/** @hidden */
/**
* Extracts a specific type of receipts from a list of receipts.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Extracts a specific type of receipts from a list of receipts.
* Extracts a specific type of receipt from a list of receipts.
*

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Torres-ssf Torres-ssf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside @danielbate suggestions, this looks good to me

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
64.12%(+0%) 69.69%(+0.03%) 72.66%(+0%) 64.56%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)
78.08%
(+1.37%)
84%
(+0%)
88.81%
(+0%)

/** @hidden */
/**
* Extracts a transfer operation from a transaction receipt, determining the addresses and types
* of the sender and receiver, along with the transferred asset details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* of the sender and receiver, along with the transferred asset details.
* of the sender and receiver, along with the transferred asset details.
*

Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just one comment

* @param inputs - Transaction inputs containing account information
* @param receipts - Transaction receipts containing withdrawal details
* @param baseAssetId - The ID of the asset being withdrawn
* @returns Array of withdrawal operations with sender, recipient, and asset details
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @returns Array of withdrawal operations with sender, recipient, and asset details
* @returns Array of withdrawal operations with sender, recipient, and asset id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document hidden transaction summary methods
5 participants