-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document hidden tx summary methods #3408
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #3408 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
packages/account/src/providers/transaction-summary/get-transaction-summary.ts
Show resolved
Hide resolved
@@ -42,15 +42,24 @@ import type { | |||
AbiMap, | |||
} from './types'; | |||
|
|||
/** @hidden */ | |||
/** | |||
* Extracts a specific type of receipts from a list of receipts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Extracts a specific type of receipts from a list of receipts. | |
* Extracts a specific type of receipt from a list of receipts. | |
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/account/src/providers/transaction-summary/get-transaction-summary.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside @danielbate suggestions, this looks good to me
Coverage Report:
Changed Files:
|
/** @hidden */ | ||
/** | ||
* Extracts a transfer operation from a transaction receipt, determining the addresses and types | ||
* of the sender and receiver, along with the transferred asset details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* of the sender and receiver, along with the transferred asset details. | |
* of the sender and receiver, along with the transferred asset details. | |
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just one comment
* @param inputs - Transaction inputs containing account information | ||
* @param receipts - Transaction receipts containing withdrawal details | ||
* @param baseAssetId - The ID of the asset being withdrawn | ||
* @returns Array of withdrawal operations with sender, recipient, and asset details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @returns Array of withdrawal operations with sender, recipient, and asset details | |
* @returns Array of withdrawal operations with sender, recipient, and asset id. |
Summary
This PR adds some hidden tx summary methods to the API docs.
Checklist