Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxy contracts in fuels deploy #3123

Closed
arboleya opened this issue Sep 6, 2024 · 1 comment · Fixed by #3190
Closed

Add support for proxy contracts in fuels deploy #3123

arboleya opened this issue Sep 6, 2024 · 1 comment · Fixed by #3190
Assignees
Labels
feat Issue is a feature

Comments

@arboleya
Copy link
Member

arboleya commented Sep 6, 2024

Intro

It goes like this:

[proxy]
enabled = true

Docs:

Tips

We currently have this helper:

export function readForcToml(path: string) {

It is used here, but the toml contents get discarded when the method finishes:

const forcToml = readForcToml(workspace);

The final touch will probably have to be around here:

const { waitForResult } = await contractFactory.deploy(deployConfig);

Ultimately, we should probably persist the TOML contents with the other artifacts.

Notes

I wonder if it'd be a good moment to address this issue together with:

@danielbate
Copy link
Member

The behaviour of the deployment depends on the existence of both the proxy table and the enabled and address flags. I've created the following decision tree to illustrate the process:

Screenshot 2024-09-19 at 16 48 35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants