Skip to content

Commit 936b982

Browse files
remove metrics that can be calculated by prometheus
1 parent 7337407 commit 936b982

File tree

2 files changed

+4
-33
lines changed

2 files changed

+4
-33
lines changed

committer/src/setup.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ pub fn fee_metrics_tracker(
330330
config: &config::Config,
331331
registry: &Registry,
332332
) -> Result<tokio::task::JoinHandle<()>> {
333-
let fee_metrics_tracker = FeeMetricsTracker::new(api, config.fee_algo_config().sma_periods);
333+
let fee_metrics_tracker = FeeMetricsTracker::new(api);
334334

335335
fee_metrics_tracker.register_metrics(registry);
336336

packages/services/src/fee_metrics_tracker.rs

Lines changed: 3 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,12 @@ pub mod service {
88

99
use crate::{
1010
fees::{Api, Fees},
11-
state_committer::SmaPeriods,
1211
Result, Runner,
1312
};
1413

1514
#[derive(Debug, Clone)]
1615
struct FeeMetrics {
1716
current: IntGauge,
18-
short: IntGauge,
19-
long: IntGauge,
2017
}
2118

2219
impl Default for FeeMetrics {
@@ -27,40 +24,19 @@ pub mod service {
2724
))
2825
.expect("metric config to be correct");
2926

30-
let short = IntGauge::with_opts(Opts::new(
31-
"short_term_blob_tx_fee",
32-
"The short term fee for a transaction with 6 blobs",
33-
))
34-
.expect("metric config to be correct");
35-
36-
let long = IntGauge::with_opts(Opts::new(
37-
"long_term_blob_tx_fee",
38-
"The long term fee for a transaction with 6 blobs",
39-
))
40-
.expect("metric config to be correct");
41-
42-
Self {
43-
current,
44-
short,
45-
long,
46-
}
27+
Self { current }
4728
}
4829
}
4930

5031
impl<P> RegistersMetrics for FeeMetricsTracker<P> {
5132
fn metrics(&self) -> Vec<Box<dyn Collector>> {
52-
vec![
53-
Box::new(self.metrics.current.clone()),
54-
Box::new(self.metrics.short.clone()),
55-
Box::new(self.metrics.long.clone()),
56-
]
33+
vec![Box::new(self.metrics.current.clone())]
5734
}
5835
}
5936

6037
#[derive(Clone)]
6138
pub struct FeeMetricsTracker<P> {
6239
fee_provider: P,
63-
sma_periods: SmaPeriods,
6440
metrics: FeeMetrics,
6541
}
6642

@@ -83,10 +59,9 @@ pub mod service {
8359
}
8460

8561
impl<P> FeeMetricsTracker<P> {
86-
pub fn new(fee_provider: P, sma_periods: SmaPeriods) -> Self {
62+
pub fn new(fee_provider: P) -> Self {
8763
Self {
8864
fee_provider,
89-
sma_periods,
9065
metrics: FeeMetrics::default(),
9166
}
9267
}
@@ -106,12 +81,8 @@ pub mod service {
10681
};
10782

10883
let current = tx_fees_for_last_n_blocks(1.try_into().expect("not zero")).await?;
109-
let short_term = tx_fees_for_last_n_blocks(self.sma_periods.short).await?;
110-
let long_term = tx_fees_for_last_n_blocks(self.sma_periods.long).await?;
11184

11285
self.metrics.current.set(current);
113-
self.metrics.short.set(short_term);
114-
self.metrics.long.set(long_term);
11586

11687
Ok(())
11788
}

0 commit comments

Comments
 (0)