Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SYMFONY_VERSION constant accordingly #354

Open
verfriemelt-dot-org opened this issue Mar 22, 2024 · 3 comments · May be fixed by #360
Open

update SYMFONY_VERSION constant accordingly #354

verfriemelt-dot-org opened this issue Mar 22, 2024 · 3 comments · May be fixed by #360

Comments

@verfriemelt-dot-org
Copy link
Contributor

heyho, just a minor nitpick, can you ensure to update the version defined here:

https://github.com/FriendsOfSymfony1/symfony1/blob/master/lib/autoload/sfCoreAutoload.class.php#L12

:) thx for you effort with this legacy codebase!

@connorhu
Copy link
Collaborator

Thank you for the reminder! We will add this step to the release process. Am I right @thePanz ? :) (Just for the sake of science: what if I make a GHA process that does the release process on tagging. Including version number setting? I wonder what that would look like.).

@thePanz
Copy link
Member

thePanz commented Mar 22, 2024

Thank you for the reminder! We will add this step to the release process. Am I right @thePanz ? :) (Just for the sake of science: what if I make a GHA process that does the release process on tagging. Including version number setting? I wonder what that would look like.).

Having an automated tagging would be great, or a pipeline making sure that the tagging is correct.
Never did that before tho

@connorhu
Copy link
Collaborator

@thePanz Sebastian has just done one of his projects. What do you think about such a solution? sebastianbergmann/foal@b0e3537

@connorhu connorhu linked a pull request Mar 27, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@thePanz @verfriemelt-dot-org @connorhu and others