add(phpcs) modern strpos

Author: connorhu

.php-cs-fixer.dist.php

@@ -29,7 +29,9 @@
         'import_symbols' => true,
         'leading_backslash_in_global_namespace' => true,
     ],
+    'modernize_strpos' => true,
 ])
+    ->setRiskyAllowed(true)
     ->setCacheFile('.php-cs-fixer.cache')
     ->setFinder($finder)
 ;

lib/autoload/sfCoreAutoload.class.php

@@ -515,7 +515,7 @@ public static function make()
         $classes = '';
         foreach ($files as $file) {
             $file = str_replace(DIRECTORY_SEPARATOR, '/', $file);
-            $class = basename($file, false === strpos($file, '.class.php') ? '.php' : '.class.php');
+            $class = basename($file, !str_contains($file, '.class.php') ? '.php' : '.class.php');
 
             $contents = file_get_contents($file);
             if (false !== stripos($contents, 'class '.$class)

lib/cache/sfEAcceleratorCache.class.php

@@ -118,9 +118,9 @@ public function clean($mode = \sfCache::ALL)
         $infos = eaccelerator_list_keys();
         if (is_array($infos)) {
             foreach ($infos as $info) {
-                if (false !== strpos($info['name'], $this->getOption('prefix'))) {
+                if (str_contains($info['name'], $this->getOption('prefix'))) {
                     // eaccelerator bug (http://eaccelerator.net/ticket/287)
-                    $key = 0 === strpos($info['name'], ':') ? substr($info['name'], 1) : $info['name'];
+                    $key =   str_starts_with($info['name'], ':') ? substr($info['name'], 1) : $info['name'];
                     if (!eaccelerator_rm($key)) {
                         return false;
                     }

lib/cache/sfFileCache.class.php

@@ -103,7 +103,7 @@ public function remove($key)
      */
     public function removePattern($pattern)
     {
-        if (false !== strpos($pattern, '**')) {
+        if (str_contains($pattern, '**')) {
             $pattern = str_replace(\sfCache::SEPARATOR, DIRECTORY_SEPARATOR, $pattern).self::EXTENSION;
 
             $regexp = self::patternToRegexp($pattern);

lib/command/sfCommandApplication.class.php

@@ -559,7 +559,7 @@ protected function fixCgi()
         ini_set('html_errors', false);
         ini_set('magic_quotes_runtime', false);
 
-        if (false === strpos(PHP_SAPI, 'cgi')) {
+        if (!str_contains(PHP_SAPI, 'cgi')) {
             return;
         }
 

lib/command/sfCommandManager.class.php

@@ -318,7 +318,7 @@ protected function parseShortOption($argument)
      */
     protected function parseLongOption($argument)
     {
-        if (false !== strpos($argument, '=')) {
+        if (str_contains($argument, '=')) {
             list($name, $value) = explode('=', $argument, 2);
 
             if (!$this->optionSet->hasOption($name)) {

lib/config/sfRoutingConfigHandler.class.php

@@ -91,7 +91,7 @@ protected function parse($configFiles)
         foreach ($config as $name => $params) {
             if (
                 (isset($params['type']) && 'collection' == $params['type'])
-                || (isset($params['class']) && false !== strpos($params['class'], 'Collection'))
+                || (isset($params['class']) &&   str_contains($params['class'], 'Collection'))
             ) {
                 $options = isset($params['options']) ? $params['options'] : [];
                 $options['name'] = $name;

lib/controller/sfWebController.class.php

@@ -39,7 +39,7 @@ public function genUrl($parameters = [], $absolute = false)
             }
 
             // relative URL?
-            if (0 === strpos($parameters, '/')) {
+            if (str_starts_with($parameters, '/')) {
                 return $parameters;
             }
 
@@ -111,7 +111,7 @@ public function convertUrlStringToParameters($url)
         // routeName?
         if ($url && '@' == $url[0]) {
             $route = substr($url, 1);
-        } elseif (false !== strpos($url, '/')) {
+        } elseif (str_contains($url, '/')) {
             list($params['module'], $params['action']) = explode('/', $url);
         } elseif (!$queryString) {
             $route = $givenUrl;

lib/debug/sfDebug.class.php

@@ -240,7 +240,7 @@ public static function shortenFilePath($file)
         }
 
         foreach (['sf_root_dir', 'sf_symfony_lib_dir'] as $key) {
-            if (0 === strpos($file, $value = \sfConfig::get($key))) {
+            if (str_starts_with($file, $value = \sfConfig::get($key))) {
                 $file = str_replace($value, strtoupper($key), $file);
 
                 break;

lib/debug/sfWebDebugPanel.class.php

@@ -117,7 +117,7 @@ public function getToggleableDebugStack($debugStack)
             $file = isset($trace['file']) ? $trace['file'] : null;
             $line = isset($trace['line']) ? $trace['line'] : null;
 
-            $isProjectFile = $file && 0 === strpos($file, \sfConfig::get('sf_root_dir')) && !preg_match('/(cache|plugins|vendor)/', $file);
+            $isProjectFile = $file &&   str_starts_with($file, \sfConfig::get('sf_root_dir')) && !preg_match('/(cache|plugins|vendor)/', $file);
 
             $html .= sprintf('<span%s>#%s &raquo; ', $isProjectFile ? ' class="sfWebDebugHighlight"' : '', $keys[$j] + 1);