Backported display_errors-handling to sf1

Author: thirsch

lib/config/sfApplicationConfiguration.class.php

@@ -128,7 +128,15 @@ public function initConfiguration()
         }
 
         // error settings
-        ini_set('display_errors', $this->isDebug() ? 'on' : 'off');
+        if (!in_array(PHP_SAPI, array('cli', 'phpdbg', 'embed'), true)) {
+          ini_set('display_errors', 0);
+        } elseif (
+            !filter_var(ini_get('log_errors'), FILTER_VALIDATE_BOOLEAN)
+            || ini_get('error_log')
+        ) {
+          // CLI - display errors only if they're not already logged to STDERR
+          ini_set('display_errors', 1);
+        }
         error_reporting(sfConfig::get('sf_error_reporting'));
 
         // initialize plugin configuration objects