Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If rollback fails, then the original exception is not being thrown. #33

Open
preexo opened this issue Sep 5, 2017 · 0 comments
Open

Comments

@preexo
Copy link

preexo commented Sep 5, 2017

https://github.com/LExpress/doctrine1/blob/fce1192e87a76e1ddcf69b3defa73e451a816c8c/lib/Doctrine/Connection/UnitOfWork.php#L152

It looks like if the rollback fails with "Rollback failed. There is no active transaction.", then we never find out what the original exception was about.

I have this happening, for whatever reason the rollback fails. Could be improved by wrapping the rollback in another try catch and appending the exception to the previous one. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant