-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
./postgresql.conf missing? #570
Comments
You should be able to rename that to postgresql.conf and map it in your volumes. I ran into an issue in my setup where the permissions were wrong so I was getting a health check failure. If you do, chmod/chown it. I just 777'd it and everything started working fine. |
I had made the changes manually to mine on the previous version but with the mapped file it just kept failing. I got a config error at line 1 and because the container loops I couldn't get onto it to check what it thinks is mounted. eventually worked out it was the name of the file hadn't updated once I realised I'd typed it incorrectly. If the original file is not present in the image and the mounted version is required to run the service it should be included in the image instead, IMO. If this is a recommendation to update the default file then it shouldn't be considered a breaking change and just a note in the install instructions. Thanks @Freika for the work you're putting into this, |
I think it's all unclear. I run the dockers with an older docker-compose.yml. That is the only file I have from where I start the containers. I don't understand where to place the postgresql.conf file. I know the dockers and files are somewhere but do I have to go there? Do I have to add two lines to the docker-compose.yml file?? Can I place the renamed example postgresql.conf file next to the docker-compose.yml file? It should be very nice to make it all a lot easier or at least more clear. I hope someone can explain me in detail what I have to do. Thanks in advance. |
The line in the docker-compose should be used as a reference, you can take
The thing is, there is basically no way to put the file into
Wherever you want, literally. Just provide correct file to it in your docker-compose. I'd say it's one of these cases where you learn something new about how docker and docker compose works. I know your struggle, went this road :) Anyway, it's clear to me current situation with postgres config isn't really obvious so I'll fix it, hopefully soon. |
I don't understand this statement at all. Why is it not as simple as adding: That is essentially what I did. My only complaint was that the example What am I misunderstanding? |
@chrisl8 hmm maybe I got mixed up here... Let's make it clear for both of us. We have Can you please show output of psql -U postgres
SHOW config_file; |
Sorry, maybe I confused what you were saying to me vs. what others are saying? Anyway, for me I think the config file is working fine. My only concern was why the file in the repo is named differently than the file in your example compose file.
|
@chrisl8 and what's the output for |
Meanwhile in 0.21.1 I made custom config optional in docker compose |
Sorry, that should have been obvious. It appears to be the contents of the
I feel like we are talking past each other here a little bit, like I'm missing what the disconnect is. Anyway, as always, thank you for the amazing tool! |
Aha, so it really is working like that, I'll have to try it for my own instance. Thank you!
Yeah it seems so 😅 |
I think @chrisl8 is confused why the Nonetheless making it optional inside the docker compose as already done, resolves this confusion and docker-compose should work out of the box again. |
The new compose file references
./postgresql.conf
, but no such file is provided. Instead a file called postgres.conf.example is provided instead. Is that the file that we are supposed to use?It seems strange to require renaming the file to use settings that I presume are good defaults.
The text was updated successfully, but these errors were encountered: