Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to select only suggestion for "visit" #471

Open
pheerai opened this issue Dec 1, 2024 · 2 comments
Open

Unable to select only suggestion for "visit" #471

pheerai opened this issue Dec 1, 2024 · 2 comments

Comments

@pheerai
Copy link

pheerai commented Dec 1, 2024

Describe the bug
When browsing through my suggested visits and editing a suggestion with just one actual proposal, selecting that won't update the visit.

Version
0.18.2

To Reproduce
Steps to reproduce the behavior:

  1. You need to have a "Suggested" visit with just one suggestion.
  2. Got to "Visits" -> "Suggested"
  3. Use the "map" feature on the visit with just one suggestion
  4. Select the suggestion from the dropdown

Expected behavior
The visit should indicate the selection by changing its name.

Screenshots
(Pretty hard to do a screenshot of "nothing" happening)

Logs
UI Only, Backend not involved

Additional context
This seems to also apply to the first entry in the dropdown in general, even with multiple suggestions, it is necessary to select any but the first entry, then switch back to the first for the name change to occur.

@mkaltner
Copy link

mkaltner commented Dec 20, 2024

Same here. If there are multiple options it updates to the selected item in the dropdown but if there's just a single option, it doesn't update the name.

Also, it would be nice to be able to add pre-defined places like Home, Work, etc. I'm starting fresh and I have to confirm Home many many times. If I confirm one, will the system re-learn and identify the rest as Home? Currently, every time I click map on the same Home place, it just lists "Suggested place" 100's of times.

@ragnarkarlsson
Copy link

I've found myself in the same position. I'd suggest adding a default option of "Select location" so that when you select any reverse geocoded location it will work. This will allow for those scenarios where there is only one location suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants