-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inform users if an entry has a not typical page number #583
Comments
An italicised District happens when the This flag can be set when one or more of the following applies:
|
This information clearly needs to go on the Entry Information page. I suggest we start by implementing that. At present Districts are italicised in the Results page if their distSusp flag is set. There are three reasons I can think of for reconsidering this approach:
On further investigation, the 'suspect district' information is packaged into the DistrictFlag field. If it is not zero, there is an issue to report (not necessarily with the District itself). So putting an indicator like a 'dagger' symbol in each result page entry would provide the same information as the italicisation does, in BMD1. |
Queries about the District, Volume and Page should be added to the appropriate cell in the Entry Information page table. They could be complemented by a textual description, based on those found in BMD1 if you follow a link to a questionable district. |
@richardofsussex See Why Don’t Screen Readers Always Read What’s on the Screen? Part 1: Punctuation and Typographic Symbols and scroll down to "Safe Characters (all screen readers read the characters out loud)". And then read the following section, "Unread Characters (meaning that at least one screen reader will not read the character out loud)". In fact the whole page has a lot of relevant information. (Although the article was written in 2014, screen reader development proceeds relatively slowly and many relevant institutions do not have the resources to update them in a timely way.) Also, information that comes after the link is likely to be overlooked by a screen reader user who has already followed the link and it will not appear in the links listing for that page. I'm thinking that placing the symbol before the link or better still making it part of the link would be more helpful. |
If instead I put an |
@richardofsussex Mind you, on reflection, a simple number is not really helpful. The link needs to be "Page 123", with "Page" in a span with Similarly, "Oldham" (in this case) would need "District" in an equivalent span, plus anything else that makes no sense out of context. Sorry. |
Following discussion with Jason, we think that the qualification in the Entry Information page should be placed in the relevant table cell when the query is specific to one item of data (e.g. the District name), and placed in a separate note under the whole table when it could be any one of a number of data items which is actually suspect/wrong. Our initial instinct is not to put any indication that a District (etc.) is 'suspect' in the Results page entries. The alternative would be to include a textual note saying, e.g. 'Suspect data: see Entry information page for details'. |
@AlOneill do you have any input on this approach? |
@DeniseColbert @richardofsussex |
See the beta site for an updated strategy which I hope will meet accessibility requirements. |
When I listen to the table row for the page number I hear: |
@Vino-S is looking into it, but the code I submitted doesn't have any daggers in it, and does indeed contain text with |
Try beta now. The code isn't perfect, but at least you can see the idea I am trying to implement. (Look for Jane Partington, Sep 1837 - Dec 1845, volume 20 page 181 as an example.) |
@richardofsussex I've been thinking some more about the awkwardness of the filter and sort for SR users and how that would impact the The setup seems quite complicated in that, in order to sort or apply a filter, a screen reader user is required to navigate from the table to the form and then back to the table, each time going via the rotor, probably. Altogether, quite a lot of faff. And most of the faff is understandable — we offer to sort on several criteria that do not have their own column. However, it does seem unfair on SR users. And it makes for a long caption, explaining not only the structure of the table but also how to sort or filter the results, because the how is not obvious if you cannot see the page. One alternative would be to put each of the sortable items in their own column and put buttons in the table header cells to do the sorting. This could make problems for mobile-size screens. I seem to remember that REG solved this by using a description list on mobile screens (and using device-sniffing to decide whether to supply a table or a Food for thought. |
I've just updated the code so that the links do work. In the process I have added |
The filter and sort controls should, I think, be a separate story. I note that the BMD2 project made a decision, some time ago, to go with a single-cell block for the core information of one entry within the Search results table, i.e. to do it differently from the other two projects. So going [back] to one cell per data item [for sortable data] is something of a regression. I'm concerned about us going round in circles and never getting to the finishing line. |
I'll leave you to fix the layout issues on the Details page. A reminder that all children of Can we try giving the form on the results page an accessible label? I suggest It is only a "regression" (a rather loaded term in everyday English) iff [sic] you believe that those who made the decision fully understood the consequences for SR users. |
@AlOneill do we have any documentation on our CSS grid styles? I see .grid__item's within .grid__item's. Does a .grid__item have to be in an immediate HTML child element of .grid (e.g. |
Presumably we don't use the 'official' CSS Grid framework: https://www.w3schools.com/css/css_grid.asp ? |
@richardofsussex Nested Our |
To provide a textual description if an entry has a page number which is not typical for the district. Analyze cases where a district is shown in italics on FreeBMD1.
The text was updated successfully, but these errors were encountered: