Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry config.json loading in case of connectivity problems #1467

Open
indeyets opened this issue Oct 22, 2021 · 4 comments
Open

Retry config.json loading in case of connectivity problems #1467

indeyets opened this issue Oct 22, 2021 · 4 comments

Comments

@indeyets
Copy link
Contributor

Config.json can fail because of temporary connectivity issues. It would be beneficial to implement retry policy here.

I suggest to do the following:

  1. Attempt to load. In case of exception (Network Error) wait for 1 second
  2. Retry … (wait for 2 seconds)
  3. Retry … (Replace "Loading…" with "Some network problems. Still loading…". wait for 5 seconds)
  4. Retry … (wait for 10 seconds)
  5. Retry … Fallback to current error
@n1313
Copy link
Contributor

n1313 commented Oct 22, 2021

Should we try bundling config.json into client bundle?

@indeyets
Copy link
Contributor Author

I think we should not. It is a way to have reusable packages and to ad-hoc reconfiguration. It may be incomplete currently, but still occasionally useful.

@n1313
Copy link
Contributor

n1313 commented Oct 22, 2021

How does ad-hoc reconfiguration work currently?

@indeyets
Copy link
Contributor Author

@n1313 I talk about manual editing of this file on server to change cookie name or API path without running ansible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants