Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove large-scale flow U(t) from BarotropicQG #135

Closed
navidcy opened this issue Nov 14, 2020 · 2 comments · Fixed by #147
Closed

Remove large-scale flow U(t) from BarotropicQG #135

navidcy opened this issue Nov 14, 2020 · 2 comments · Fixed by #147
Assignees
Labels
🧹 cleanup ❓ question Further information is requested

Comments

@navidcy
Copy link
Member

navidcy commented Nov 14, 2020

I'm tempted to remove the large-scale flow from BarotropicQG as it's too specific and makes the code hard to penetrate for first-time users. Perhaps move U(t) functionality in an example or a different module...

@navidcy navidcy added ❓ question Further information is requested 🧹 cleanup labels Nov 14, 2020
@glwagner
Copy link
Member

alternatively you can make sol a NamedTuple and optionally activate U(t) evolution if sol.U isn't nothing

@navidcy
Copy link
Member Author

navidcy commented Nov 18, 2020

@glwagner, I feel that FourierFlows/FourierFlows.jl#212 should be dealt first. Then what you suggest would be smoother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 cleanup ❓ question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants