Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit on order in makefilter to ensure positivity of the filter in physical space #181

Open
glwagner opened this issue Jun 16, 2020 · 2 comments

Comments

@glwagner
Copy link
Member

@kburns suggests it may be so.

decay = 15*log(10) / (outerK-innerK)^order # decay rate for filtering function

@navidcy
Copy link
Member

navidcy commented Jun 16, 2020

This is a wavenumber filter. When you say "physical space" you mean when you take, e.g., ifft(filter)?

Why does the wavenumber filter have to be positive in physical space...? Am I missing something @glwagner?

@navidcy
Copy link
Member

navidcy commented Jun 16, 2020

OK, I see..
You are making the point that changing the order can make the filter transition from something like a smooth gaussian filter to a "top-hat" filter in wavenumber space. And this would induce ringing artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants