Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images are overwritten without confirmation after rotation and back button #241

Open
7 tasks done
ngrcld opened this issue Jun 20, 2024 · 6 comments · May be fixed by #349
Open
7 tasks done

images are overwritten without confirmation after rotation and back button #241

ngrcld opened this issue Jun 20, 2024 · 6 comments · May be fixed by #349
Labels
bug Something is not working

Comments

@ngrcld
Copy link

ngrcld commented Jun 20, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.1.3

Affected Android/Custom ROM version

Android 13

Affected device model

Motorola Edge 30

How did you install the app?

GitHub releases

Steps to reproduce the bug

  1. open an image
  2. click on image rotation icon
  3. make a rotation
  4. press back arrow (or Android back button)

Expected behavior

nothing should happen to the image, because the confirmation button wasn't pressed

Actual behavior

the image is re-saved rotated, overwriting the original image, without prompt

Screenshots/Screen recordings

The thumbnail is not updated, but the actual image is now rotated.
Don't check the image with Google Photos because it caches images... use another viewer or check the image checksum before and after the rotation

Additional information

No response
@ngrcld ngrcld added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Jun 20, 2024
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Jun 20, 2024
@Violet-RM
Copy link

Still affects 1.2.0 release, on LineageOS 21 on Pixel 3

@rkolbaskin
Copy link

The relevant code is in app/src/main/kotlin/org/fossify/gallery/fragments/PhotoFragment.kt at the end of PhotoFragment::onDestroyView method.

This comes from SimpleGallery times. Original creator was very insistent on implicit rotation save being the correct behavior.
I really hope this will change under new management and I won't have to patch every single release for myself.

@Aga-C
Copy link
Member

Aga-C commented Oct 28, 2024

@rkolbaskin You can create a PR with this change. This bug doesn't have needs triage label, so if the fix is valid, we will accept it.

@rkolbaskin
Copy link

@Aga-C My whole experience with kotlin (or java for that matter) is removing those 6 lines of code. I don't even remember how I managed to find out what part of the code to edit and I am not sure what side effects it might have. I don't think I am qualified to make such pull requests.

@rkolbaskin
Copy link

Actually no. I do remember. I found implicit save added in commit 18277c1 commented with "save rotated images automatically".

@Aga-C
Copy link
Member

Aga-C commented Oct 28, 2024 •
edited
Loading

We're not Simple Mobile Tools - if needed, we can change something done by the original maintainer, even if it was done purposefully. It makes more sense to accept changes with the tick button.

Aga-C added a commit to Aga-C/Gallery that referenced this issue Oct 30, 2024
@Aga-C
Removed autosaving rotation (FossifyOrg#241)
3329f3e
@Aga-C Aga-C linked a pull request Oct 30, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed autosaving rotation (#241) Aga-C/Gallery
4 participants
@ngrcld @rkolbaskin @Aga-C @Violet-RM