Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still some dangling references to p hanging around #24

Closed
DOSull opened this issue Jun 9, 2018 · 2 comments
Closed

Still some dangling references to p hanging around #24

DOSull opened this issue Jun 9, 2018 · 2 comments

Comments

@DOSull
Copy link

DOSull commented Jun 9, 2018

There seem to be a few places where method signatures expect to receive p which I think is a reference to a processing canvas no longer in use? These make refactoring the code per #5 tricky (and also should be removed as a matter of principle anyway...)

@nicklally
Copy link
Collaborator

you are correct about 'p' being a remnant from earlier, when we were using p5's instance mode. they should be able to be removed without a problem (i thought i had, but not surprising that i missed a couple). feel free to delete them when you see them!

@nicklally
Copy link
Collaborator

okay, i think i've deleted all p references in function and methods, so i am closing this issue. thanks for pointing this out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants