Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Enzyme tests only on CUDA CI machine #2478

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Run Enzyme tests only on CUDA CI machine #2478

merged 1 commit into from
Aug 20, 2024

Conversation

pxl-th
Copy link
Member

@pxl-th pxl-th commented Aug 20, 2024

Since Enzyme explicitly adds CUDA to its environment, run its tests only on CUDA CI machines to prevent crashing other jobs.

FYI @wsmoses

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.32%. Comparing base (d1ff714) to head (3dfe290).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2478      +/-   ##
==========================================
+ Coverage   36.38%   41.32%   +4.94%     
==========================================
  Files          37       37              
  Lines        2119     2110       -9     
==========================================
+ Hits          771      872     +101     
+ Misses       1348     1238     -110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pxl-th pxl-th merged commit dd9b644 into master Aug 20, 2024
9 of 11 checks passed
@pxl-th pxl-th deleted the pxl-th/enzyme branch August 20, 2024 15:05
@wsmoses
Copy link
Contributor

wsmoses commented Aug 20, 2024

@pxl-th hm this is a bit weird, since Enzyme CPU tests would be equally good to check, no?

@pxl-th
Copy link
Member Author

pxl-th commented Aug 20, 2024

Then it is probably better to run Enzyme CPU tests when CPU tests are enabled and Enzyme CUDA tests when CUDA tests are enabled.
We were getting this crashes on other backends, because Enzyme was trying to run CUDA tests on them:
https://buildkite.com/julialang/flux-dot-jl/builds/4820#01916a11-6182-4203-b661-ad9c97b96c86

@ToucheSir
Copy link
Member

Buildkite should still be running Enzyme CPU tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants