Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lockfiles getting out of sync #428

Open
greenape opened this issue Feb 27, 2019 · 4 comments
Open

Lockfiles getting out of sync #428

greenape opened this issue Feb 27, 2019 · 4 comments
Assignees
Labels
bug Something isn't working development discussion tests Issues relating to tests

Comments

@greenape
Copy link
Member

If dependabot updates the lock file for flowmachine's Pipfile, then the lock files in integration tests and docs will be out of sync with flowmachine's. Same will happen if we add a package to one of the child project lock files.

@greenape greenape added bug Something isn't working tests Issues relating to tests development labels Feb 27, 2019
@greenape
Copy link
Member Author

(Can't think of any obvious way to fix that, but worth mentioning)

@greenape
Copy link
Member Author

greenape commented Mar 7, 2019

Possible solution - remove flowmachine etc. from the integration test and docs pipfiles, install their dependencies using bash thus:

PIPENV_PIPFILE="../flowapi/Pipfile" pipenv install --ignore-pipfile and the packages themselves so:
pipenv install --skip-lock ../flowapi

Bit of a pain for running tests docs in PyCharm, because you need to make sure the install gets invoked. Doesn't protect you where an automated update updates a dependency of both, because it'll only update it in one, and the version you'd end up running the tests with will be the one from whichever was last in the script.

@greenape
Copy link
Member Author

greenape commented May 9, 2019

dependabot/feedback#460

@greenape
Copy link
Member Author

This by itself is a major argument in favour of migrating away from our monorepo.

@Thingus Thingus self-assigned this Oct 8, 2021
@greenape greenape removed the P-Now label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development discussion tests Issues relating to tests
Projects
None yet
Development

No branches or pull requests

2 participants