Skip to content

Commit 76dc5ce

Browse files
committed
WIP: clarify that DefaultDynamicTheme goes on the AppShellConfigurator
Target: 802ccee deprecate: deprecate DynamicTheme.initialize(AppShellSettings)
1 parent 9e3de4f commit 76dc5ce

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public class AppShellConfiguratorImpl implements AppShellConfigurator {
6767

6868
The annotation is read when the application starts, so the default theme also applies to sessions that did not load `index.html` (for example, after the server restarts while a page is open, or when `index.html` is served from a cache).
6969

70-
Initializing `DynamicTheme` from the `configurePage` method of the `AppShellConfigurator` (i.e. calling `DynamicTheme.LUMO.initialize(settings)`) is deprecated, because the default theme is only known after `index.html` has been served at least once. Replace that call with the `@DefaultDynamicTheme` annotation.
70+
Initializing `DynamicTheme` from the `configurePage` method of the `AppShellConfigurator` (i.e. calling `DynamicTheme.LUMO.initialize(settings)`) is deprecated, because the default theme is only known after `index.html` has been served at least once. Replace that call by annotating the `AppShellConfigurator` with `@DefaultDynamicTheme`.
7171

7272
When targeting Vaadin 14-25 or 23-25, the `AppShellConfigurator` approach cannot be used due to framework and library limitations.
7373
To resolve this, you must create a configuration file `src/test/resources/META-INF/dynamic-theme.properties` with the following content:

0 commit comments

Comments
 (0)