Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5858 add FlowCrypt secure messaging options in Gmail's actions menu #5870

Merged
merged 12 commits into from
Nov 29, 2024

Conversation

martgil
Copy link
Collaborator

@martgil martgil commented Nov 23, 2024

This PR add's secure compose's messaging options within Gmail's action menu.

Here is the short demo of the proposed changes of this PR:

Screencast.from.2024-11-23.15-44-54.webm

close #5858


Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@martgil martgil requested a review from sosnovsky as a code owner November 23, 2024 09:30
@martgil martgil changed the title Issue 5858 add secure compose action menus live test #5858 add FlowCrypt secure messaging options in Gmail's actions menu Nov 23, 2024
@martgil martgil marked this pull request as draft November 23, 2024 10:12
@martgil martgil marked this pull request as ready for review November 25, 2024 03:55
@martgil
Copy link
Collaborator Author

martgil commented Nov 25, 2024

Hi @sosnovsky - Good day, this one is ready for a review. thanks!

@martgil martgil marked this pull request as draft November 26, 2024 09:33
@martgil
Copy link
Collaborator Author

martgil commented Nov 27, 2024

Hi @sosnovsky - I think there are still some more fragile tests that are barely passing. For example in this PR there are approximately 3 tests, takes turns not to pass for every consecutive runs.

@martgil martgil marked this pull request as ready for review November 29, 2024 06:30
@martgil
Copy link
Collaborator Author

martgil commented Nov 29, 2024

Hi @sosnovsky - Good day. Is it possible for us to merge this first. The live test for this one tends to fail pretty often so I'd like to request if its possible? thanks!

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks!

@sosnovsky sosnovsky merged commit b88601d into master Nov 29, 2024
13 checks passed
@sosnovsky sosnovsky deleted the issue-5858-add-secure-compose-action-menus-live-test branch November 29, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlowCrypt's secure forward icon button become less obvious in UI
2 participants