-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5858 add FlowCrypt secure messaging options in Gmail's actions menu #5870
#5858 add FlowCrypt secure messaging options in Gmail's actions menu #5870
Conversation
Hi @sosnovsky - Good day, this one is ready for a review. thanks! |
Hi @sosnovsky - I think there are still some more fragile tests that are barely passing. For example in this PR there are approximately 3 tests, takes turns not to pass for every consecutive runs. |
Hi @sosnovsky - Good day. Is it possible for us to merge this first. The live test for this one tends to fail pretty often so I'd like to request if its possible? thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 👍
extension/js/content_scripts/webmail/gmail/gmail-element-replacer.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now, thanks!
This PR add's secure compose's messaging options within Gmail's action menu.
Here is the short demo of the proposed changes of this PR:
Screencast.from.2024-11-23.15-44-54.webm
close #5858
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):