Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue with Outlook - oauth screen #716

Closed
tomholub opened this issue Sep 5, 2019 · 4 comments
Closed

Continue with Outlook - oauth screen #716

tomholub opened this issue Sep 5, 2019 · 4 comments
Assignees
@DenBond7
Labels
user experience
Milestone
1.1.0

Comments

@tomholub
Copy link
Collaborator

tomholub commented Sep 5, 2019

Similar to what we do with Gmail, if possible
@tomholub tomholub added this to the soon milestone Sep 5, 2019
@tomholub tomholub mentioned this issue Sep 5, 2019
Open
8 tasks
@tomholub
Copy link
Collaborator Author

tomholub commented Sep 5, 2019

part of #714

@DenBond7
Copy link
Collaborator

DenBond7 commented Jun 1, 2020 •
edited
Loading

for me https://developer.android.com/training/id-auth/authenticate

https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-v2-android
https://docs.microsoft.com/en-us/azure/active-directory/develop/tutorial-v2-android
https://docs.microsoft.com/en-us/exchange/client-developer/legacy-protocols/how-to-authenticate-an-imap-pop-smtp-application-by-using-oauth

https://support.microsoft.com/en-us/office/pop-and-imap-email-settings-for-outlook-8361e398-8af4-4e97-b147-6c6c4ac95353?ui=en-us&rs=en-us&ad=us

https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow

https://stackoverflow.com/questions/61597263/office-365-xoauth2-for-imap-and-smtp-authentication-fails
https://docs.microsoft.com/en-us/azure/active-directory/develop/id-tokens
https://developer.yahoo.com/oauth2/guide/openid_connect/decode_id_token.html#validate-the-id-token
http://blog.udinic.com/2013/04/24/write-your-own-android-authenticator/

DenBond7 added a commit that referenced this issue Jul 31, 2020
@DenBond7
Modified UI to show a button with text "Continue with Outlook..".| #716
6797c29
@DenBond7
Copy link
Collaborator

DenBond7 commented Aug 3, 2020 •
edited
Loading

for me

  • encrypt token before saving

  • Use .addQueryParameter("state", requestCode) for better security

  • PKCE for OAuth 2.0

DenBond7 added a commit that referenced this issue Aug 5, 2020
@DenBond7
Added a temp version which works with Microsoft OAuth 2.0.| #716
f240fe7
DenBond7 added a commit that referenced this issue Aug 6, 2020
@DenBond7
Added checking "state" before continue authentication. Added handling…
40571ca 
… errors from the auth screen.| #716
DenBond7 added a commit that referenced this issue Aug 7, 2020
@DenBond7
Moved OAuth2Helper to "com.flowcrypt.email.api.oauth".| #716
d4f7fae
DenBond7 added a commit that referenced this issue Aug 7, 2020
@DenBond7
Applied appauth libs for OAuth.| #716
02611bf
DenBond7 added a commit that referenced this issue Aug 12, 2020
@DenBond7
Got a stable version without the token refreshing.| #716
9df7464
@DenBond7
Copy link
Collaborator

DenBond7 commented Aug 13, 2020 •
edited
Loading

for me

  • test revoke access via a site

  • test adding an account twice

  • test adding an account from Settings -> Accounts

DenBond7 added a commit that referenced this issue Aug 13, 2020
@DenBond7
Refactored code.| #716
eaddd70
DenBond7 added a commit that referenced this issue Aug 13, 2020
@DenBond7
Added a temp realization of authenticator.| #716
f4ad3a2
DenBond7 added a commit that referenced this issue Aug 13, 2020
@DenBond7
Modified FlowcryptAccountAuthenticator. Refactored code.| #716
d9c956c
DenBond7 added a commit that referenced this issue Aug 14, 2020
@DenBond7
Added an ability to handle errors when we fetch access_token.| #716
36cf32b
DenBond7 added a commit that referenced this issue Aug 14, 2020
@DenBond7
Added using ".well-known/openid-configuration" to load configuration.| …
149acfc 
…#716
DenBond7 added a commit that referenced this issue Aug 14, 2020
@DenBond7
Fixed a navigation bug.| #716
cfe136b
DenBond7 added a commit that referenced this issue Aug 14, 2020
@DenBond7
Refactored code.| #716
3c9f5c2
DenBond7 added a commit that referenced this issue Aug 14, 2020
@DenBond7
Added the token encryption when we store an access token to AccountMa…
23c909b 
…nager. Fixed a bug of the message sending.| #716
DenBond7 added a commit that referenced this issue Aug 25, 2020
@DenBond7
Improved JWT validation.| #716
83c1126
DenBond7 added a commit that referenced this issue Aug 25, 2020
@DenBond7
Added printing exceptions logs.| #716
b4d3649
DenBond7 added a commit that referenced this issue Aug 25, 2020
@DenBond7
Fixed a bug with the token expiration.| #716
0dc0f50
DenBond7 added a commit that referenced this issue Aug 26, 2020
@DenBond7
Handled the account removing.| #716
8ca1027
DenBond7 added a commit that referenced this issue Aug 26, 2020
@DenBond7
Improved handling errors during the token refreshing.| #716
1c3416c
DenBond7 added a commit that referenced this issue Aug 26, 2020
@DenBond7
Fixed a bug of updating labels. Refactored code.| #716
31ab716
DenBond7 added a commit that referenced this issue Aug 26, 2020
@DenBond7
Handled the auth failure error.| #716
b636360
DenBond7 added a commit that referenced this issue Aug 26, 2020
@DenBond7
Fixed adding duplicate accounts.| #716
6085fdf
DenBond7 added a commit that referenced this issue Aug 27, 2020
@DenBond7
Modified a logic of resolving base settings.| #716
16dbd57
@DenBond7 DenBond7 modified the milestones: soon, 1.1.0 Aug 27, 2020
DenBond7 added a commit that referenced this issue Aug 27, 2020
@DenBond7
Added using right data to connect Microsoft accounts.| #716
b46e84e
@DenBond7 DenBond7 mentioned this issue Jan 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenBond7 DenBond7

Labels
user experience
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@DenBond7 @tomholub