Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass phrase in memory. Make a backup #1253

Closed
DenBond7 opened this issue May 26, 2021 · 3 comments · Fixed by #1295
Closed

Pass phrase in memory. Make a backup #1253

DenBond7 opened this issue May 26, 2021 · 3 comments · Fixed by #1295
Assignees
@DenBond7
Milestone
1.1.9

Comments

@DenBond7
Copy link
Collaborator

as a part of #372
@DenBond7 DenBond7 added this to the 1.1.9 milestone May 26, 2021
@DenBond7 DenBond7 self-assigned this May 26, 2021
@DenBond7
Copy link
Collaborator Author

@tomholub
Currently, before making a backup we check a passphrase (is it strong enough). So we have to ask for all missing passphrases to continue. Am I right?

@DenBond7 DenBond7 mentioned this issue Jun 14, 2021
Merged
4 tasks
@tomholub
Copy link
Collaborator

Yes, I would ask for all pass phrases for keys that the user wants to back up.

DenBond7 added a commit that referenced this issue Jun 15, 2021
@DenBond7
Added EmptyPassphraseException. Added KeysStorage.getFingerprintsWith…
c70d8a0 
…EmptyPassphrase(). Modified some logic.| #1253
DenBond7 added a commit that referenced this issue Jun 15, 2021
@DenBond7
Updated navVersion to '2.3.5'.| #1253
ce885b4
DenBond7 added a commit that referenced this issue Jun 16, 2021
@DenBond7
Added fragment realization for SearchBackupsInEmailActivity and Backu…
e21efdf 
…pKeysActivity.| #1253
DenBond7 added a commit that referenced this issue Jun 16, 2021
@DenBond7
Renamed some classes.| #1253
05a4b75
DenBond7 added a commit that referenced this issue Jun 16, 2021
@DenBond7
Moved BackupKeysFragment to 'ui.activity.fragment' | #1253
f6e0900
DenBond7 added a commit that referenced this issue Jun 16, 2021
@DenBond7
Moved SearchBackupsInEmailFragment to 'ui.activity.fragment' | #1253
7437519
DenBond7 added a commit that referenced this issue Jun 16, 2021
@DenBond7
Renamed activity_backup_settings to fragment_search_backups_in_email.…
ddab138 
…xml | #1253
DenBond7 added a commit that referenced this issue Jun 16, 2021
@DenBond7
Renamed activity_backup_keys to fragment_backup_keys | #1253
22ba9db
DenBond7 added a commit that referenced this issue Jun 16, 2021
@DenBond7
Refactored code to support git history.| #1253
5a88137
DenBond7 added a commit that referenced this issue Jun 16, 2021
@DenBond7
Modified FixNeedPassphraseIssueDialogFragment to use nav.components a…
da40503 
…nd viewbinding.| #1253
DenBond7 added a commit that referenced this issue Jun 17, 2021
@DenBond7
Added a logic to show FixNeedPassphraseIssueDialogFragment. Refactore…
a508a6d 
…d code.| #1253
@DenBond7 DenBond7 mentioned this issue Jun 17, 2021
Merged
4 tasks
DenBond7 added a commit that referenced this issue Jun 17, 2021
@DenBond7
Refactored code.| #1253
074551c
DenBond7 added a commit that referenced this issue Jun 17, 2021
@DenBond7
Fixed lint warnings. Fixed a bug in BackupKeysFragment.| #1253
d2618ff
DenBond7 added a commit that referenced this issue Jun 17, 2021
@DenBond7
Fixed BackupKeysFragmentTest.| #1253
dba0d20
DenBond7 added a commit that referenced this issue Jun 17, 2021
@DenBond7
Added a few accounts to the email server(single_backup, no_backups).| #…
ffc6f7c 
…1253
DenBond7 added a commit that referenced this issue Jun 17, 2021
@DenBond7
Update docker-mailserver/docker-compose.yml to use flowcrypt/flowcryp…
b269a29 
…t-email-server:0.0.4. Added add_user.sh| #1253
DenBond7 added a commit that referenced this issue Jun 17, 2021
@DenBond7
Modified SearchBackupsInEmailFragmentTest. Refactored code.| #1253
661eeda
DenBond7 added a commit that referenced this issue Jun 17, 2021
@DenBond7
Added BackupKeysFragmentPassphraseInRamTest. Refactored code.| #1253
3771654
DenBond7 added a commit that referenced this issue Jun 18, 2021
@DenBond7
Fixed using DependsOnMailServer annotation for some tests.| #1253
8b6191a
@DenBond7
Copy link
Collaborator Author

1

DenBond7 added a commit that referenced this issue Jun 18, 2021
@DenBond7
BackupKeysFragmentPassphraseInRamTest. Updated tests.| #1253
ff6ee08
DenBond7 added a commit that referenced this issue Jun 18, 2021
@DenBond7
Modified code after code review.| #1253
31e0e51
DenBond7 added a commit that referenced this issue Jun 18, 2021
@DenBond7
Added deeplink "flowcrypt://make_backup".| #1253
5a524a3
DenBond7 added a commit that referenced this issue Jun 18, 2021
@DenBond7
Improved tests.| #1253
246b47a
DenBond7 added a commit that referenced this issue Jun 18, 2021
@DenBond7
Modified tests one more time.| #1253
18b2282
DenBond7 added a commit that referenced this issue Jun 21, 2021
@DenBond7
Modified SearchBackupsInEmailFragmentTest to test fragments in isolat…
5e7459c 
…ion. Refactored code.| #1253
DenBond7 added a commit that referenced this issue Jun 22, 2021
@DenBond7
Improved testing BackupKeysFragment.| #1253
e5e9363
DenBond7 added a commit that referenced this issue Jun 22, 2021
@DenBond7
Renamed some classes.| #1253
07ec66d
DenBond7 added a commit that referenced this issue Jun 22, 2021
@DenBond7
Excluded some tests from CI.| #1253
8d2f12d
DenBond7 added a commit that referenced this issue Jun 22, 2021
@DenBond7
Excluded some tests from CI.Step 2.| #1253
c9f8539
DenBond7 added a commit that referenced this issue Jun 22, 2021
@DenBond7
Excluded some tests from CI.Step 3.| #1253
149693f
DenBond7 added a commit that referenced this issue Jun 22, 2021
@DenBond7
Excluded some tests from CI.Step 4.| #1253
194abca
DenBond7 added a commit that referenced this issue Jun 22, 2021
@DenBond7
Excluded some tests from CI.Step 5.| #1253
c31d138
tomholub pushed a commit that referenced this issue Jun 22, 2021
@DenBond7
Issue #1253 passphrase in ram during making a backup (#1295)
29ae00e 
* Added EmptyPassphraseException. Added KeysStorage.getFingerprintsWithEmptyPassphrase(). Modified some logic.| #1253

* Updated navVersion to '2.3.5'.| #1253

* Added fragment realization for SearchBackupsInEmailActivity and BackupKeysActivity.| #1253

* Renamed some classes.| #1253

* Moved BackupKeysFragment to 'ui.activity.fragment' | #1253

* Moved SearchBackupsInEmailFragment to 'ui.activity.fragment' | #1253

* Renamed activity_backup_settings to fragment_search_backups_in_email.xml | #1253

* Renamed activity_backup_keys to fragment_backup_keys | #1253

* Refactored code to support git history.| #1253

* Modified FixNeedPassphraseIssueDialogFragment to use nav.components and viewbinding.| #1253

* Added a logic to show FixNeedPassphraseIssueDialogFragment. Refactored code.| #1253

* Refactored code.| #1253

* Fixed lint warnings. Fixed a bug in BackupKeysFragment.| #1253

* Fixed BackupKeysFragmentTest.| #1253

* Added a few accounts to the email server(single_backup, no_backups).| #1253

* Update docker-mailserver/docker-compose.yml to use flowcrypt/flowcrypt-email-server:0.0.4. Added add_user.sh| #1253

* Modified SearchBackupsInEmailFragmentTest. Refactored code.| #1253

* Added BackupKeysFragmentPassphraseInRamTest. Refactored code.| #1253

* Fixed using DependsOnMailServer annotation for some tests.| #1253

* BackupKeysFragmentPassphraseInRamTest. Updated tests.| #1253

* Modified code after code review.| #1253

* Added deeplink "flowcrypt://make_backup".| #1253

* Improved tests.| #1253

* Modified tests one more time.| #1253

* Improved testing BackupKeysFragment.| #1253

* Renamed some classes.| #1253

* Excluded some tests from CI.| #1253

* Excluded some tests from CI.Step 2.| #1253

* Excluded some tests from CI.Step 3.| #1253

* Excluded some tests from CI.Step 4.| #1253

* Excluded some tests from CI.Step 5.| #1253
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DenBond7 DenBond7

Labels
None yet
Projects
None yet
Milestone
1.1.9
Development

Successfully merging a pull request may close this issue.

Issue 1253 passphrase in ram during making a backup FlowCrypt/flowcrypt-android
2 participants
@DenBond7 @tomholub