Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

[PRO-155] Create empty commit on pr if the HEAD_SHA is from a user outside the org (forked branch) #72

Open
NicHaley opened this issue Jan 16, 2024 · 1 comment
Assignees
Labels
Improvement Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync

Comments

@NicHaley
Copy link
Contributor

Review comments do not currently work if the HEAD_SHA is from a forked branch. This is because the GH review comment API requires a commit_id, which in this case belong to a user outside the org. The method will thus give a 401.

A possible solution would be to create an empty commit if the HEAD_SHA is from outside the org. Then, pass the empty commit SHA to the review comment command.

Ideally, this functionality should be attached to a flag so that the org can determine if they want to opt into this functionality.

From SyncLinear.com | PRO-155

@NicHaley NicHaley self-assigned this Jan 16, 2024
@NicHaley NicHaley added Improvement Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync labels Jan 16, 2024
@NicHaley
Copy link
Contributor Author

Another solution in the mean time would be to put an action like this in front: https://github.com/marketplace/actions/create-empty-commit

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Improvement Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant