-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Highlight.JS from PrismJS - Discuss #44
Comments
If you wanted to switch to backend rendering / pygments, I have my old implementation archived here, which you're free to rip off: https://github.com/vsalvino/coderedcms-codeblock The one thing I'd do differently is change the language list dropdown to a user-entered string instead, as the list is HUGE. |
Highlight.js does not support line numbering. Is line numbering going to still be supported? |
@smark-1 There seems to be a plugin we can leverage, but good question: |
The current versioning is based off of PrismJS. What would the versioning scheme be after switching? |
@smark-1 That's a great question. We might fork this to something like |
PrismJS no longer seems to be maintained. There are also some underlying issues with CSS namespacing that conflict with Wagtail's admin, particularly around the CSS class named
comment
.I'm considering switching to highlight.js as our underlying syntax highlighting library.
Pros:
Cons:
I wanted to open this issue for discussion to our users before moving in this direction. Thoughts?
The text was updated successfully, but these errors were encountered: