Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace single backslash doublequote with triple backslash doublequote in HTML report #2209

Closed
wants to merge 1 commit into from
Closed

fix: Replace single backslash doublequote with triple backslash doublequote in HTML report #2209

wants to merge 1 commit into from

Conversation

andrii-zubenko
Copy link

Fixes #2169

Test Plan

How do we know the code works?
Paste

[
  {
    "label": "deviceName com.myApp.tests.SomeTest#exampleTest",
    "items": [
      {
        "label": "Error in 'single quotes \"Double quotes\"'",
        "url": "https://console.firebase.google.com/project/"
      }
    ]
  }
]

into INJECT-DATA-HERE field in Inline.html and observe broken html file

then paste

[
  {
    "label": "deviceName com.myApp.tests.SomeTest#exampleTest",
    "items": [
      {
        "label": "Error in 'single quotes \\\"Double quotes\\\"'",
        "url": "https://console.firebase.google.com/project/"
      }
    ]
  }
]

and verify html is not broken

Checklist

  • Documented
  • Unit tested
  • Integration tests updated

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@andrii-zubenko
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Feb 5, 2022
@github-actions
@andrew-zu has signed the CLA from Pull Request #2209
932a757
@andrii-zubenko
Copy link
Author

recheck

@andrii-zubenko andrii-zubenko changed the title Replace single backslash with triple backslash fix: Replace single backslash doublequote with triple backslash doublequote in HTML report Feb 5, 2022
@andrii-zubenko
Copy link
Author

recheck

@andrii-zubenko andrii-zubenko deleted the replace-single-backslash-doublequote branch February 8, 2022 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Android Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTML report does not display any info
1 participant
@andrii-zubenko