Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ElasticLoadBalancingV2 TargetGroups, provisioned concurrency support #26

Merged
merged 7 commits into from
Jan 8, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jan 6, 2024

Proposed changes

  • Added ElasticLoadBalancingV2 TargetGroups support.
  • Added support for functions with provisioned concurrency/SnapStart configured via Serverless.
  • Added package @flagsmith scope, an NPM publish job triggered by GitHub releases, and bumped the package version.

Types of changes

What types of changes does your code introduce to the plugin?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

The logic to determine whether a given function has provisioned concurrency/SnapStart configured is simplifed greatly on behalf of the framework's internal code that sets a targetAlias property to the function configuration in any of those cases. This is not documented anywhere, but that code has been stable across both the major versions. For greater compatibility with other plugins that may rely on this, we set and/or update the functions' targetAliases with proper names and logical IDs.

@khvn26 khvn26 requested a review from matthewelwell January 6, 2024 17:46
@khvn26 khvn26 force-pushed the feat/elbv2-and-target-aliases branch from 7ef17fa to 7f1d752 Compare January 8, 2024 09:17
README.md Outdated Show resolved Hide resolved
lib/CfTemplateGenerators/Lambda.js Outdated Show resolved Hide resolved
lib/CfTemplateGenerators/Lambda.js Show resolved Hide resolved
khvn26 and others added 2 commits January 8, 2024 16:59
Co-authored-by: Matthew Elwell <[email protected]>
@khvn26 khvn26 requested a review from matthewelwell January 8, 2024 17:08
@khvn26 khvn26 merged commit 6a4d75d into main Jan 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants