Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Getting flags by identity - iOS #4010

Conversation

jackforesightmobile
Copy link
Contributor

@jackforesightmobile jackforesightmobile commented May 22, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add documentation and code examples to the iOS docs for getting flags by an identity.

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 1:55pm

Copy link

vercel bot commented May 22, 2024

@jackforesightmobile is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the docs Documentation updates label May 22, 2024
@dabeeeenster
Copy link
Contributor

Can we include some Traits in here too?

@jackforesightmobile
Copy link
Contributor Author

Can we include some Traits in here too?

Traits are already in there just above @dabeeeenster
image

@matthewelwell
Copy link
Contributor

@jackforesightmobile I think Ben is asking whether we can show that you can set traits when requesting the flags for an identity as this is the case in most of our SDKs. I'm not sure if that's the case here?

@dabeeeenster
Copy link
Contributor

@jackforesightmobile I think Ben is asking whether we can show that you can set traits when requesting the flags for an identity as this is the case in most of our SDKs. I'm not sure if that's the case here?

Yep this is what I meant - sorry wasnt clear. We need to show how to make a call where you Identify the user and provide some trait data (e.g. devicetype=iOS, version=3.4.1) and then get their flags back, all in 1 call.

@jackforesightmobile
Copy link
Contributor Author

@dabeeeenster I discussed with @matthewelwell and there's no method for this currently on the iOS SDK. He said he's going to raise a separate ticket to implement this in another piece of work.

@matthewelwell
Copy link
Contributor

@dabeeeenster @jackforesightmobile looks like it actually already exists here.

@matthewelwell matthewelwell added this pull request to the merge queue May 24, 2024
Merged via the queue into Flagsmith:main with commit 1ae51a4 May 24, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants