Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: load build time-cached flags #41

Closed
strugee opened this issue Apr 28, 2023 · 4 comments
Closed

Feature request: load build time-cached flags #41

strugee opened this issue Apr 28, 2023 · 4 comments

Comments

@strugee
Copy link

strugee commented Apr 28, 2023

I'd love to be able to do https://docs.flagsmith.com/guides-and-examples/integration-approaches#build-time-flag-retrieval for our backend, but it seems to be unsupported by the Flagsmith Python SDK.

I've also read https://docs.flagsmith.com/guides-and-examples/integration-approaches#caching-flags-on-a-server but would prefer to cache at build time because there are less moving parts (I don't have to worry about being able to receive webhooks from Flagsmith, and I can reuse the SDK's background update thread to retrieve from Flagsmith, instead of having to wire that up myself).

@dabeeeenster
Copy link
Contributor

cc @matthewelwell @gagantrivedi @kyle-ssg Do we have an agreed spec for the static flag file format? Is it simply the output of https://github.com/Flagsmith/flagsmith-cli? If we do we can start buidling this out in our server side SDKs?

@strugee happy to take pull requests on this!

@matthewelwell
Copy link
Contributor

This is related to the issue in our main repository here: Flagsmith/flagsmith#2024

@strugee I'd love to know if you are looking for this feature to use the python client in an 'offline mode' or as a fallback in case the SDK is unable to retrieve data from the Flagsmith API.

@matthewelwell
Copy link
Contributor

This was added here: #50.

@strugee
Copy link
Author

strugee commented Aug 8, 2023

@matthewelwell sorry I missed your question earlier and I'm glad to see this added 🎉

For posterity, we wanted this for the "what if the Flagsmith API goes down" case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants