Identities are not correctly URL encoded

[mjwills-k]

The below code generates an identity of ZZGGHH_abc rather than the expected ZZGGHH_abc&h=g. I suspect some of your code is not correctly url encoding inputs.

Note that the code does work if you pass in traits. So I suspect

flagsmith-dotnet-client/Flagsmith.FlagsmithClient/FlagsmithClient.cs

Line 366 in 4a83292

url += $"?identifier={identity}{(transient ? $"&transient={transient}" : "")}";

needs fixing, but not

flagsmith-dotnet-client/Flagsmith.FlagsmithClient/FlagsmithClient.cs

Line 361 in 4a83292

jsonBody = JsonConvert.SerializeObject(new { identifier = identity, traits, transient });

.

using Flagsmith;

namespace TestsForFlagSmith
{
    public class IssueForFlagSmith : TestsCommon
    {
        protected static readonly Lazy<FlagsmithClient> _flagsmithClient = new Lazy<FlagsmithClient>(() => new FlagsmithClient("keyhere"));

        [Test]
        public async Task CorrectIdentityIsGenerated()
        {
            var identity = "ZZGGHH_abc&h=g";

            var flags = await _flagsmithClient.Value.GetIdentityFlags(identity);
        }
    }
}

[matthewelwell]

Thanks for raising this @mjwills-k - we'd gratefully receive a PR to fix this.

[mjwills-k]

https://github.com/Flagsmith/flagsmith-dotnet-client/pull/126/files