Move departments logic to enable redirect - addresses #455

Author: portableant

app/Http/Controllers/departmentsController.php

@@ -37,9 +37,10 @@ public function index(): View
     public function details(string $slug): View|Response
     {
         $departments = Departments::find($slug);
-        $staff = StaffProfiles::findByDepartment($departments['data'][0]['id']);
         if (empty($departments['data'])) {
             return response()->view('errors.404', [], 404);
+        } else {
+            $staff = StaffProfiles::findByDepartment($departments['data'][0]['id']);
         }
         return view('departments.details', compact('departments', 'staff'));
     }

config/missing-page-redirector.php

@@ -474,12 +474,12 @@
         # podcasts
         '/conversations/podcasts/episode' => '/conversations/podcasts/',
         # Department changes July 2022
-        '/about-us/departments/antiquities' => '/about-us/departments/collections-and-research',
-        '/about-us/departments/applied-arts' => '/about-us/departments/collections-and-research',
-        '/about-us/departments/coins-and-medals' => '/about-us/departments/collections-and-research',
-        '/about-us/departments/manuscripts-and-printed-books' => '/about-us/departments/collections-and-research',
-        '/about-us/departments/paintings-drawings-and-prints' => '/about-us/departments/collections-and-research',
-        '/about-us/departments/research' => '/about-us/departments/collections-and-research',
+        'about-us/departments/antiquities' => '/about-us/departments/collections-and-research',
+        'about-us/departments/applied-arts' => '/about-us/departments/collections-and-research',
+        'about-us/departments/coins-and-medals' => '/about-us/departments/collections-and-research',
+        'about-us/departments/manuscripts-and-printed-books' => '/about-us/departments/collections-and-research',
+        'about-us/departments/paintings-drawings-and-prints' => '/about-us/departments/collections-and-research',
+        'about-us/departments/research' => '/about-us/departments/collections-and-research',
     ],
 
 ];