Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make the validator instance thread-safe? #381

Open
ewoutkramer opened this issue Oct 16, 2024 · 0 comments
Open

Should we make the validator instance thread-safe? #381

ewoutkramer opened this issue Oct 16, 2024 · 0 comments

Comments

@ewoutkramer
Copy link
Member

This discussion https://chat.fhir.org/#narrow/stream/179171-dotnet/topic/Encountered.20an.20error.20while.20loading.20schema surfaces the issue that most of our code is not thread safe. It does not have to be, and in fact most classes in Microsoft's stack aren't either, but in this case it does mean that to safely do multi-threaded validation, one needs to create multiple instances of the validator and the resolvers, which will mean multiple instances of caches.

This is an inconvenience that we might want to fix in a future (major?) release of the validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant