You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe the conditional handling inside the action could be implemented more concisely by conditionally running steps based in the input instead of always running and checking inside a shell. E.g. instead of
- name: Check if .NET is installedrun: | if $INPUT_DOTNET_VALIDATION_ENABLED || $INPUT_SUSHI_ENABLED; then if ! command -v dotnet &> /dev/null then echo "dotnet could not be found. Please see actions/setup-dotnet to set it up before running this action." exit 1 fi fishell: bash
- name: Check if .NET is installedif: ${{ inputs.DOTNET_VALIDATION_ENABLED || inputs.INPUT_SUSHI_ENABLED }}run: | if ! command -v dotnet &> /dev/null then echo "dotnet could not be found. Please see actions/setup-dotnet to set it up before running this action." exit 1 fishell: bash
This would show the Check if .NET is installed step as disabled in the GitHub workflow view.
(As another nit-picky aside: kebab-case for input parameters generally seems more common in GitHub actions)
The text was updated successfully, but these errors were encountered:
I believe the conditional handling inside the action could be implemented more concisely by conditionally running steps based in the input instead of always running and checking inside a shell. E.g. instead of
This would show the
Check if .NET is installed
step as disabled in the GitHub workflow view.(As another nit-picky aside: kebab-case for input parameters generally seems more common in GitHub actions)
The text was updated successfully, but these errors were encountered: