Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fhir check likely won't ever fail without specifying the --fail flag #20

Open
chgl opened this issue Jul 7, 2023 · 0 comments
Open

Comments

@chgl
Copy link

chgl commented Jul 7, 2023

In https://github.com/FirelyTeam/firely-terminal-pipeline/blob/main/action.yml#L241, fhir check is ran without specifying the --fail flag. This means that even if validation fails, the action still completes successfully, which is most likely not the expected behavior.

See:

$ fhir validate patient-bundle.json
warning: Evaluation of FhirPath for constraint 'GeburtsdatumRundenAufQuartal' failed: Invocation of function 'matches' failed: Cannot cast from 'Date' to '.NET type String'
error: Instance failed constraint GeburtsdatumRundenAufQuartal "Geburtsdatum darf nicht tagesgenau angegben werden. Das Geburtsdatum MUSS quartalsweise auf-/abgerundet werden."
Result: INVALID

$ echo $?
0

(I can't run check since its a licensed feature, but I believe the commands behave identically).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant