Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ToXml and ToJson work via the pocos, not PocoElementNode #2923

Open
ewoutkramer opened this issue Oct 17, 2024 · 2 comments
Open

Make ToXml and ToJson work via the pocos, not PocoElementNode #2923

ewoutkramer opened this issue Oct 17, 2024 · 2 comments

Comments

@ewoutkramer
Copy link
Member

ewoutkramer commented Oct 17, 2024

ToXml(Base) and ToJson(Base) still work via PocoElementNode, but should work via the more native route. This is in principle independent of the new direct implementation of ITypedElement, but in line with making the new serializers work on IScopedNode. It also takes these two extension methods logicalky out of the domain of typedelement, and into the poco domain.

@ewoutkramer
Copy link
Member Author

Actually, we should go after all "transformations" and see which ones should be done via POCO's now.

Image

@ewoutkramer
Copy link
Member Author

This means we need to remove the JsonBuilder and XmlBuilder and make up our mind what to support from the legacy SerializerSettings classes. Too much for alpha1, will need to postpone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant