Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library Names may need to be able handle dashes and any dot notation for namespace #643

Open
baseTwo opened this issue Dec 3, 2024 · 0 comments

Comments

@baseTwo
Copy link
Collaborator

baseTwo commented Dec 3, 2024

Created from a previous PR:

          Looks good. This covers most.. We may need to handle dashes in library names and any dot notation for namespace in the future.

Originally posted by @richfirely in #531 (review)

ResourceFileName does not allow the name of the resource (e.g. Library or Measure) to have hypens '-' or underscores '_'. The underscores are explicitly prohibited as per specification for CQL Library Names, but the hypens are not.

This creates a problem, how to distinguish the parts in a Resource file name which could be either two or three parts where: xxx-yyy or yyy-zzz is xxx is the resource type (e.g. Library or Measure, etc), yyy is the name of the resource and zzz the version. It would be impossible to parse cases such as:

  • Library-Common-1.0.0 (is Library-Common the library name, or just Common and the type is specified?)

Currently the NCQA cql files contain underscores, so they are invalid and should be renamed as part of this PR.
image

@baseTwo baseTwo changed the title We may need to handle dashes in library names and any dot notation for namespace in the future. Library Names may need to be able handle dashes and any dot notation for namespace Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant