Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoize library defines (2.0) #600

Open
baseTwo opened this issue Oct 14, 2024 · 1 comment
Open

Memoize library defines (2.0) #600

baseTwo opened this issue Oct 14, 2024 · 1 comment
Labels
Milestone

Comments

@baseTwo
Copy link
Collaborator

baseTwo commented Oct 14, 2024

A follow-up on the performance optimisation that was done in #575 where library classes were generated as singletons that contain no state, thus removing any previous memorization of defines.

A new solution must be found, probably that it moves to the CqlContext in an efficient manner

@baseTwo
Copy link
Collaborator Author

baseTwo commented Oct 17, 2024

Since this ticket was created, the 1.0 implementation updated their solution to put the Lazy<> and CqlContext state back into libraries, only for those that have context defined, while leaving the other libraries as singletons. See PR #590

So when this ticket is implemented, it must be decided to copy the 1.0 solution, or continue finding an optimal way to put the state in the context as per the original issue description.

@baseTwo baseTwo added this to the 2024 Q4 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant