Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal enhancement for VersionedIdentifier #550

Open
baseTwo opened this issue Sep 17, 2024 · 0 comments
Open

Internal enhancement for VersionedIdentifier #550

baseTwo opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels
refactor Structural code changes without changing functionality

Comments

@baseTwo
Copy link
Collaborator

baseTwo commented Sep 17, 2024

as a follow-up on

  • Refactor - Rename NameAndVersion/LibraryKey to VersionedIdentifer #262

      Since your doing this shouldn't we take this opportunity to make this also remove the need for getting parts and building strings? This is off the top of my head so please forgive.
      VersionedIdentifier .ToFileName <-- which always has the dash naming convention that we agreed on.
      VersionedIdentifier .Name
      VersionedIdentifier .Version
      VersionedIdentifier .ToString() -- which results in the proper pipe format, but no pipe if version is null.
      VersionedIdentifier .ToUri or ToCanonical("https...") which results in the full uri
    
      _Originally posted by @richfirely in https://github.com/FirelyTeam/firely-cql-sdk/issues/546#issuecomment-2355507435_
    
  • Replace the tuple with an internal ErrorOr result type

  • Rather return the ErrorOr type than a string

  • VersionedIdentifier should be safely castable to a string if possible

  • The methods above will be extension methods

@baseTwo baseTwo added this to the 2024 Q3 (September WGM) milestone Sep 17, 2024
@baseTwo baseTwo added the refactor Structural code changes without changing functionality label Sep 17, 2024
@baseTwo baseTwo self-assigned this Sep 17, 2024
@baseTwo baseTwo changed the title VersionedIdentifier enhancement Internal enhancement for VersionedIdentifier Sep 18, 2024
@baseTwo baseTwo removed this from the 2024 Q3 (September WGM) milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Structural code changes without changing functionality
Projects
None yet
Development

No branches or pull requests

1 participant