Generate Element.Id/Extension.Url as normal FHIR primitive properties, not primitives. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of .net primitive.
# Conflicts: # src/Microsoft.Health.Fhir.CodeGen/Language/Firely/CSharpFirely2.cs
Kasdejong
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuned the code generator so it no longer generates
Element.idandExtension.urlas special primitive .NET properties, they are now normal FHIR primitives instead.It also contains an (unrelated) hack to make sure the ObjectValue of the FHIR Integer64 type is a bit more flexible. This is temporary and will be removed when we are done with FirelyTeam/firely-net-sdk#2967. It is necessary to add this hack for now, since I had inadvertedly made a manual change of the same intent in generated code, which of course otherwise would be lost after running codegen with this PR again.