fix(client): don't call validate() during deserialization if we don't have to (#516)

Author: stainless-app[bot]

finch-java-core/src/main/kotlin/com/tryfinch/api/core/BaseDeserializer.kt

@@ -11,6 +11,7 @@ import com.fasterxml.jackson.databind.JsonMappingException
 import com.fasterxml.jackson.databind.JsonNode
 import com.fasterxml.jackson.databind.deser.ContextualDeserializer
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer
+import com.tryfinch.api.errors.FinchInvalidDataException
 import kotlin.reflect.KClass
 
 abstract class BaseDeserializer<T : Any>(type: KClass<T>) :
@@ -29,6 +30,13 @@ abstract class BaseDeserializer<T : Any>(type: KClass<T>) :
 
     protected abstract fun ObjectCodec.deserialize(node: JsonNode): T
 
+    protected fun <T> ObjectCodec.deserialize(node: JsonNode, type: TypeReference<T>): T =
+        try {
+            readValue(treeAsTokens(node), type)
+        } catch (e: Exception) {
+            throw FinchInvalidDataException("Error deserializing", e)
+        }
+
     protected fun <T> ObjectCodec.tryDeserialize(
         node: JsonNode,
         type: TypeReference<T>,

finch-java-core/src/main/kotlin/com/tryfinch/api/models/DocumentRetreiveResponse.kt

@@ -165,16 +165,16 @@ private constructor(
 
             when (type) {
                 "w4_2020" -> {
-                    tryDeserialize(node, jacksonTypeRef<W42020>()) { it.validate() }
-                        ?.let {
-                            return DocumentRetreiveResponse(w42020 = it, _json = json)
-                        }
+                    return DocumentRetreiveResponse(
+                        w42020 = deserialize(node, jacksonTypeRef<W42020>()),
+                        _json = json,
+                    )
                 }
                 "w4_2005" -> {
-                    tryDeserialize(node, jacksonTypeRef<W42005>()) { it.validate() }
-                        ?.let {
-                            return DocumentRetreiveResponse(w42005 = it, _json = json)
-                        }
+                    return DocumentRetreiveResponse(
+                        w42005 = deserialize(node, jacksonTypeRef<W42005>()),
+                        _json = json,
+                    )
                 }
             }
 

finch-java-core/src/main/kotlin/com/tryfinch/api/models/JobAutomatedCreateParams.kt

@@ -337,16 +337,17 @@ private constructor(
 
                 when (type) {
                     "data_sync_all" -> {
-                        tryDeserialize(node, jacksonTypeRef<DataSyncAll>()) { it.validate() }
-                            ?.let {
-                                return Body(dataSyncAll = it, _json = json)
-                            }
+                        return Body(
+                            dataSyncAll = deserialize(node, jacksonTypeRef<DataSyncAll>()),
+                            _json = json,
+                        )
                     }
                     "w4_form_employee_sync" -> {
-                        tryDeserialize(node, jacksonTypeRef<W4FormEmployeeSync>()) { it.validate() }
-                            ?.let {
-                                return Body(w4FormEmployeeSync = it, _json = json)
-                            }
+                        return Body(
+                            w4FormEmployeeSync =
+                                deserialize(node, jacksonTypeRef<W4FormEmployeeSync>()),
+                            _json = json,
+                        )
                     }
                 }