-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird characters in place of terminal escape sequences on Windows Console #474
Comments
If possible, we enable virtual terminal processing, which is necessary for using terminal escape sequences on instances of the Windows Console. When enabling virtual terminal processing fails, we completely avoid using escape sequences to prevent weird characters to be printed to the console. Fixes FiloSottile#474
If possible, we enable virtual terminal processing, which is necessary for using terminal escape sequences on instances of the Windows Console. When enabling virtual terminal processing fails, we completely avoid using escape sequences to prevent weird characters to be printed to the console. Fixes FiloSottile#474
Still an issue with age v1.2.0. NOTE rage 0.11.0 does NOT have this issue. Occurs for passphrase encryption both when entering a password and also auto-generating a passphrase. Spurious control characters prepended to messages that are displayed in Windows CMD:
On screen the "?" look like left-facing arrows Code that triggers this appears to be clearLine() Line 74 in 176e245
Best thing right now is either ignore it or use rage. I tried using mintty/cash and age does NOT work at under that (just hangs), rage works but uses GUI pinentry for password. You can use mintty/cmd, that does work and does avoid garbage control characters. |
Environment
What were you trying to do
I was trying to encrypt a file with a passphrase.
What happened
On both Windows PowerShell and cmd.exe, terminal escape sequences do not work by default. As a result, I obtained the following output, containing weird characters on screen.
As a side note, I actually discovered this issue while trying to use the same functions as yours to ask for a passphrase. I strongly believe that this behavior is present since the introduction of escape sequences in 349ed5e. This commit post-dates age version v1.0.0, so it may be the case that not many people have encountered this issue, but I think that it would negatively impact the UX for Windows users from now on (indeed, v1.1.0 and v1.1.1 just came out).
I'm going to make a PR to address this issue as a follow-up.
P.S.: sorry for not disclosing this issue before the v1.1.0 release, I didn't see it coming!
The text was updated successfully, but these errors were encountered: