Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More refined sizing for Mobile Devices #3

Open
FilledStacks opened this issue Nov 6, 2019 · 5 comments
Open

More refined sizing for Mobile Devices #3

FilledStacks opened this issue Nov 6, 2019 · 5 comments
Labels
enhancement New feature or request p1

Comments

@FilledStacks
Copy link
Owner

Currently we have only Desktop, Tablet, Mobile and Watch. As we know there are many different sizes in even the mobile devices. I suggest we add a Large, Medium and Small sizing within the mobile devices as an additional builder function to supply.

@FilledStacks FilledStacks added the enhancement New feature or request label Nov 6, 2019
@ghost
Copy link

ghost commented Mar 16, 2020

@FilledStacks did you add this feature? Is there any doc about it?

@FilledStacks FilledStacks reopened this Mar 16, 2020
@FilledStacks
Copy link
Owner Author

@eherediadev it's not. I probably closed the wrong issue. Still need that to be implemented.

@FilledStacks
Copy link
Owner Author

The master branch actually has the refined size functionality in here. there are some unit tests failing. But I think that's only due to the sizing not mapping nicely.

Currently we never get the small size which is fine. For this issue to be completed we should have a guide that shows which screenType will be returned for which sizes (using our default sizes, or sizes supplied to the builder). We should also do the same for the new refinedSize enums and builders that we've created. once that's done we can push the new version out and close this issue.

@hajajmaor
Copy link
Contributor

How can you define sm md lg screens on mobile?
There are a lot of phones with different resolutions out there.

@FilledStacks
Copy link
Owner Author

I think that was merged in @hajajmaor You can see how to use it by looking at the code here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p1
Projects
None yet
Development

No branches or pull requests

2 participants