From 38f4ce8c04fb59471489f9024ec18cfe0d357c60 Mon Sep 17 00:00:00 2001
From: TippyFlits <james@filoz.org>
Date: Tue, 7 Apr 2026 17:14:04 +0100
Subject: [PATCH] feat: standardise SP approval review tracking with issue
 template

Introduces a standard SP approval review issue template in tpm-utils and updates the approval runbook to use it as the source of truth.

Removes duplicated field definitions from the runbook and ensures all SP approval reviews are tracked consistently with clear triggers, UTC timestamps, investigation windows, diagnosis, and outcomes.

The template captures:
- review trigger and timing
- failing metrics and thresholds
- investigation window and maintenance context
- communication with SPs
- diagnosis and classification of issues
- decision, actions taken, and supporting evidence

This improves operational consistency, auditability, and handover between approvers as we approach mainnet production readiness.
---
 .github/ISSUE_TEMPLATE/sp-approval-review.md | 96 ++++++++++++++++++++
 1 file changed, 96 insertions(+)
 create mode 100644 .github/ISSUE_TEMPLATE/sp-approval-review.md

diff --git a/.github/ISSUE_TEMPLATE/sp-approval-review.md b/.github/ISSUE_TEMPLATE/sp-approval-review.md
new file mode 100644
index 0000000..9804dda
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/sp-approval-review.md
@@ -0,0 +1,96 @@
+---
+name: SP Approval Review
+about: Track a Storage Provider (SP) approval review and decision
+title: "[SP Approval Review] f0xxxx"
+labels: ["sp-approval-review"]
+assignees: []
+---
+
+## SP Approval Review
+
+### SP Details
+- **SP ID:**  
+- **SP Name (optional):**
+
+---
+
+### Review Trigger
+- **Time review started (UTC):**  
+- **Trigger condition:**  
+  <!-- e.g. Storage success <97%, Retrieval failures, Retention faults -->
+
+---
+
+### Metrics
+
+**Failing metric(s):**
+- 
+
+**Observed value(s):**
+- 
+
+**Threshold(s):**
+- 
+
+---
+
+### Investigation Window
+- **Investigation deadline (UTC):**  
+- **Within maintenance window?** Yes / No  
+
+---
+
+### Communication
+
+- **SP notified?** Yes / No  
+- **Channel used:**  
+  <!-- #pdp-endorsed-sp OR #fil-pdp-mainnet-launch -->
+
+- **SP response (if any):**
+  <!-- brief summary -->
+
+---
+
+### Diagnosis
+
+**Current assessment:**
+- [ ] SP-side issue  
+- [ ] Dealbot / tooling issue  
+- [ ] Network / external issue  
+- [ ] Unknown  
+
+**Notes:**
+<!-- What do we think is happening? -->
+
+---
+
+### Outcome
+
+- [ ] Recovered within investigation window  
+- [ ] Unapproved  
+
+- **Decision time (UTC):**
+
+---
+
+### Actions Taken
+
+- [ ] SP remained approved  
+- [ ] SP unapproved  
+- [ ] Follow-up issue created  
+- [ ] Escalated  
+
+---
+
+### Links & Evidence
+
+- Dashboard (spdash):  
+- Dealbot runs:  
+- Logs / errors:  
+- Related issues:  
+
+---
+
+### Notes
+
+<!-- Anything else useful for future reference -->