Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Plugin fails to load properly when installing/enabling it the first time #18

Open
lifehaschanged opened this issue May 10, 2024 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@lifehaschanged
Copy link

lifehaschanged commented May 10, 2024

When this Plugin is installed with BRAT (sandbox vault without any other plugins than BRAT):
https://github.com/TfTHacker/obsidian42-brat

It's causing many errors and showing me no sidebars and commands:

grafik

Do you plan to make this plugin available for BRAT / Community Plugin store inside Obsidian?

@lifehaschanged
Copy link
Author

lifehaschanged commented May 10, 2024

@Fevol

I have installed it manually by pasting the files main.js manifest.json styles.css into the obsidian plugins directory.
However, after activating the plugin inside Obsidian, no settings, no commands or sidebars where visible.

It would really be wonderful if you could test that in a fresh vault to see if it's just me or the current Obsidian versions.

The "field is not present in this state" error occurs on every range:

Addition: {++ ... ++}
Deletion: {-- ... --}
Comment: {>> ... <<}

@lifehaschanged
Copy link
Author

Finally a restart of the whole vault after the plugin installation solved it.
Hence you can't test this plugin in a sandbox vault, because after restart it the sandbox vault would be gone.
@Fevol It would be really helpful to inform the users that they need to restart obsidian/vault to use the plugin.

@Fevol
Copy link
Owner

Fevol commented May 10, 2024

I'm reopening this issue as I definitely do not intend for users having to restart Obsidian in order to have this plugin to work, besides, it does seem like it is some kind of race condition between the plugin initalisation and the codemirror extensions - which only occurs if the plugin is not initialised with the loading of the app.

Many thank for the detailed issue report and checking the sandbox vault. I will try to fix this as soon as I have some time again (which should be a month from now)

@Fevol Fevol reopened this May 10, 2024
@Fevol Fevol self-assigned this May 10, 2024
@Fevol Fevol added the bug Something isn't working label May 10, 2024
@Fevol Fevol changed the title Bug and Questions (BRAT/Community Plugin) [BUG] Plugin fails to load properly when installing/enabling it the first time May 10, 2024
@Fevol
Copy link
Owner

Fevol commented May 10, 2024

Addendum, potentially related to #16

@lifehaschanged
Copy link
Author

Thank you for the feedback and reopening the topic. Please excuse me for closing it so quickly. Of course, modifying the plugin to make it available to all users without a restart is much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants