Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata is not added automatically to ranges when editing in suggestion mode #11

Open
kinglion580 opened this issue Mar 8, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@kinglion580
Copy link

mode is suggestion:

Metadata is not added automatically to ranges when editing in suggestion mode:
image

add metadata is on:
image

@Fevol Fevol added the bug Something isn't working label Mar 8, 2024
@Fevol Fevol self-assigned this Mar 8, 2024
@Fevol
Copy link
Owner

Fevol commented Mar 8, 2024

By all accounts, that combination of settings should result in metadata being added.
Did you also enable "Include Metadata Extension" in the General settings

@kinglion580
Copy link
Author

yes, I enabled "Include Metadata Extension"
image

@Fevol
Copy link
Owner

Fevol commented Mar 8, 2024

Thanks for the quick response! I think I have a general idea as to why this is not working: COMMENTATOR_GLOBAL.PLUGIN_SETTINGS is currently used to generate which metadata should be added

If you are a bit familiar with the dev tools, if you debug in the function: function generate_metadata(), you should be able to find what the value for that object is at that moment. If COMMENTATOR_GLOBAL.PLUGIN_SETTINGS.add_metadata or any of the other add_... settings are false, that should be the issue.

(I've also attached a build that console.log's these values for you:)
commentator.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants