Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not inline constants used in a concat with only literals/constants. #680

Open
Luro02 opened this issue Jan 23, 2025 · 0 comments
Open
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.

Comments

@Luro02
Copy link
Collaborator

Luro02 commented Jan 23, 2025

Summary

For the below code, it suggests that one can adjust the latter two constants, by removing the + and just writing the literal.

In this case, the suggestion is not helpful.

Lint Name

No response

Reproducer

    private static final String PRINT_COLUMN_SPREAD = " ";
    private static final String PRINT_SEPARATOR_INDICATOR_ROW = PRINT_COLUMN_SPREAD + " " + PRINT_COLUMN_SPREAD;
    private static final String PRINT_SEPARATOR_UPPER_TILE_ROW = PRINT_COLUMN_SPREAD + "+" + PRINT_COLUMN_SPREAD;
@Luro02 Luro02 added bug Something isn't working false-positive A lint triggers on something that is correct. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.
Projects
None yet
Development

No branches or pull requests

1 participant