Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push results in the background #1122

Open
AlekSi opened this issue Dec 23, 2024 · 0 comments
Open

Push results in the background #1122

AlekSi opened this issue Dec 23, 2024 · 0 comments

Comments

@AlekSi
Copy link
Member

AlekSi commented Dec 23, 2024 •
edited
Loading

pusherClient.Push should not block testing other databases/configs. See https://github.com/FerretDB/dance/actions/runs/12467709173/job/34797483841 for an example.

We either should make Push async (with Close waiting until all results are pushed) or change the main function logic to push all results in the end. In both cases, that could simplify our pinging logic.
AlekSi added a commit to AlekSi/dance that referenced this issue Dec 23, 2024
@AlekSi
Add TODOs
7b9dbe5 
Refs FerretDB#1122.
@AlekSi AlekSi mentioned this issue Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlekSi