Skip to content

Commit 46b588b

Browse files
Vehicle handling fixed by MTA r22204, updated logic and min version
thank botder for having merged multitheftauto/mtasa-blue#1935
1 parent f428193 commit 46b588b

File tree

3 files changed

+1
-24
lines changed

3 files changed

+1
-24
lines changed

newmodels/client.lua

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -446,19 +446,9 @@ function setElementCustomModel(element, elementType, id)
446446
if DATANAME_VEH_HANDLING then
447447
local handling = getElementData(element, DATANAME_VEH_HANDLING)
448448
if handling then
449-
--[[
450-
451-
-- Sadly this doesn't work yet because MTA doesn't let you setVehicleHandling clientside on server-created vehicles
452-
-- I hope this changes in the future (the following PR makes it possible)
453-
-- https://github.com/multitheftauto/mtasa-blue/pull/1935
454-
455449
for property, value in pairs(handling) do
456450
setVehicleHandling(element, property, value)
457451
end
458-
459-
-- Temp solution below (sets the handling serverside)
460-
--]]
461-
triggerServerEvent(resName..":forceSetVehicleHandling", resourceRoot, element, handling)
462452
end
463453
end
464454
if DATANAME_VEH_UPGRADES then

newmodels/meta.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
<!-- IMPORTANT TO HAVE THE VERSION
1212
SPECIFIED SO THAT ADDED MODELS WORK AS EXPECTED
1313
https://nightly.mtasa.com -->
14-
<min_mta_version client="1.6.0-9.22184.0" server="1.6.0-9.22184.0"></min_mta_version>
14+
<min_mta_version client="1.6.0-9.22204.0" server="1.6.0-9.22204.0"></min_mta_version>
1515

1616
<!-- Ped Mods -->
1717
<file src="models/peds/20001.dff"/>

newmodels/server.lua

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
-- Internal events:
1010
addEvent(resName..":onDownloadFailed", true)
11-
addEvent(resName..":forceSetVehicleHandling", true)
1211

1312
local SERVER_READY = false
1413
local startTickCount = nil
@@ -48,18 +47,6 @@ if DATANAME_VEH_HANDLING then
4847
addDebugHook( "postFunction", onSetVehicleHandling, { "setVehicleHandling" })
4948
end
5049

51-
-- Temp solution (see where it's triggered from client.lua):
52-
-- It's not ideal because with a lot of players requesting handling this can cause server lag
53-
function forceSetVehicleHandling(element, handling)
54-
if not (isElement(element)) then return end
55-
if type(handling) ~= "table" then return end
56-
for property, value in pairs(handling) do
57-
setVehicleHandling(element, property, value)
58-
end
59-
-- iprint("Force set vehicle handling", element)
60-
end
61-
addEventHandler(resName..":forceSetVehicleHandling", resourceRoot, forceSetVehicleHandling, false)
62-
6350
--[[
6451
Goal: solve the issue of upgrades resetting every time the vehicle's model is changed serverside/clientside
6552
]]

0 commit comments

Comments
 (0)