Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: maybe add infinite rotate animation support? #664

Open
uuau99999 opened this issue Dec 24, 2024 · 1 comment
Open

Feature Request: maybe add infinite rotate animation support? #664

uuau99999 opened this issue Dec 24, 2024 · 1 comment
Labels
enhancement New feature or request PR welcome A pull-request for this would likely be merged

Comments

@uuau99999
Copy link

SketchyBar is awesome! I'm using it to create a media item for Spotify with album cover. It would be even more awesome if SketchyBar support rotate animation which can be applied to album cover! Thanks a lot!

@FelixKratz
Copy link
Owner

FelixKratz commented Jan 22, 2025

This is not something I would myself use but I am open for pull requests for something like this.

Start here and add a rotation field which is respected in rendering and has an update function, such that we can simply animate it with the existing animation system:

SketchyBar/src/image.h

Lines 7 to 30 in 0a502a5

struct image {
bool enabled;
float scale;
CGSize size;
CGRect bounds;
char* path;
CGImageRef image_ref;
CFDataRef data_ref;
struct shadow shadow;
struct color border_color;
float border_width;
uint32_t corner_radius;
int padding_left;
int padding_right;
int y_offset;
struct image* link;
};

@FelixKratz FelixKratz added enhancement New feature or request PR welcome A pull-request for this would likely be merged labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR welcome A pull-request for this would likely be merged
Projects
None yet
Development

No branches or pull requests

2 participants