Fixing a bug when multi-byte characters were split #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffer. The `_surrogate` field in `ByteXmlWriter` serves as a memory across buffers in these cases. However, after writing the original multi-byte character, the field was not set back to 0 which caused the XmlWriter to think there were another surrogate pair where there were none.
|
Hi @khituras! First of all, apologies for missing this PR. Thank you for pinging me. Patch makes sense, along with test, so I will merge it and release 1.3.1. |
cowtowncoder
added a commit
that referenced
this pull request
Jan 14, 2022
|
Wow great, that was fast! Thank you so much that makes my life a little easier :-)
Cheers!
… On 14. Jan 2022, at 19:39, Tatu Saloranta ***@***.***> wrote:
Hi @khituras <https://github.com/khituras>! First of all, apologies for missing this PR. Thank you for pinging me.
Patch makes sense, along with test, so I will merge it and release 1.3.1.
—
Reply to this email directly, view it on GitHub <#75 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDO44H7LRFSVY3LA4PKUETUWBUXVANCNFSM47WXCAVA>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.
|
|
@khituras Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_surrogatefield inByteXmlWriterserves as a memory across buffers in these cases. However, after writing the original multi-byte character, the field was not set back to 0 which caused the XmlWriter to think there were another surrogate pair where there were none.This could cause two sorts of errors for which this PR provides new tests. Both tests will fail when the reset of
_surrogateis removed.